Skip to content

fix(bigquery): import Mapping from collections.abc not from collections #9826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Nov 21, 2019
Merged

fix(bigquery): import Mapping from collections.abc not from collections #9826

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8152db
fix(bigquery): import Mapping from collections.abc not from collections
Nov 19, 2019
f1a9c13
fix(bigquery): importing module not class
Nov 20, 2019
548c018
Use collections_abc import from six.
tswast Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bigquery/google/cloud/bigquery/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

"""Schemas for BigQuery tables / queries."""

import collections
from collections import abc
Comment thread
tswast marked this conversation as resolved.
Outdated

from google.cloud.bigquery_v2 import types

Expand Down Expand Up @@ -281,7 +281,7 @@ def _to_schema_fields(schema):
instance or a compatible mapping representation of the field.
"""
for field in schema:
if not isinstance(field, (SchemaField, collections.Mapping)):
if not isinstance(field, (SchemaField, abc.Mapping)):
Comment thread
tswast marked this conversation as resolved.
Outdated
raise ValueError(
"Schema items must either be fields or compatible "
"mapping representations."
Expand Down