Spanner: Add PingingPool to toplevel spanner module - #6886
Merged
crwilcox merged 3 commits intoDec 10, 2018
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
The documentation at https://gcloud-python.readthedocs.io/en/stable/spanner/session-api.html#google.cloud.spanner.pool.PingingPool (not this clients but reasonable enough) states you can access it this way but you cannot as it was not included. |
tseaver
reviewed
Dec 10, 2018
tseaver
left a comment
tseaver
left a comment
Contributor
There was a problem hiding this comment.
We should probably be adding the other pool classes, too (FixedSizePool is there already):
AbstractSessionPool(users who write their own pool implementations need it.BurstyPoolTransactionPingingPool
Contributor
Author
|
Current list of impls is below. I can add TransactionPingingPool as well |
crwilcox
force-pushed
the
add-pingingpool-to-spanner-alias
branch
from
December 10, 2018 20:21
aa6c2d4 to
7aff218
Compare
tseaver
approved these changes
Dec 10, 2018
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Add PingingPool to toplevel spanner module * Add TransactionPingingPool to spanner module * Add PingingPools to spanner_v1 module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.