Skip to content

Set retain_acked_messages in seek system test#3314

Merged
lukesneeringer merged 1 commit into
masterfrom
pubsub-todo
Apr 19, 2017
Merged

Set retain_acked_messages in seek system test#3314
lukesneeringer merged 1 commit into
masterfrom
pubsub-todo

Conversation

@geigerj

@geigerj geigerj commented Apr 19, 2017

Copy link
Copy Markdown
Contributor

This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.

This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017
@geigerj geigerj changed the title Fix a system test TODO Set retain_acked_messages in seek system test Apr 19, 2017
@lukesneeringer lukesneeringer merged commit 5878b78 into master Apr 19, 2017
@lukesneeringer lukesneeringer deleted the pubsub-todo branch April 19, 2017 19:02
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.
parthea pushed a commit that referenced this pull request Mar 2, 2026
This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants