Skip to content

allow setting gRPC metadata #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
callmehiphop merged 6 commits into from
Sep 2, 2016
Merged

allow setting gRPC metadata #1546

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c112bf
allow setting gRPC metadata
stephenplusplus Aug 30, 2016
cbd23f3
set metadata per call
stephenplusplus Aug 31, 2016
eff7266
refactor and test
stephenplusplus Sep 1, 2016
6cc716b
always default to empty metadata
stephenplusplus Sep 2, 2016
9cf0c10
lint issue
stephenplusplus Sep 2, 2016
c68b260
Update grpc-service.js
stephenplusplus Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/common/src/grpc-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,9 @@ function GrpcService(config, options) {
this.grpcCredentials = grpc.credentials.createInsecure();
}

this.grpcMetadata = null;
this.grpcMetadata = new grpc.Metadata();

if (config.grpcMetadata) {
this.grpcMetadata = new grpc.Metadata();

for (var prop in config.grpcMetadata) {
if (config.grpcMetadata.hasOwnProperty(prop)) {
this.grpcMetadata.add(prop, config.grpcMetadata[prop]);
Expand Down
8 changes: 7 additions & 1 deletion packages/common/test/grpc-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,17 @@ describe('GrpcService', function() {
});

it('should default grpcMetadata to null', function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

var fakeGrpcMetadata = {};

grpcMetadataOverride = function() {
return fakeGrpcMetadata;
};

var config = extend({}, CONFIG);
delete config.grpcMetadata;

var grpcService = new GrpcService(config, OPTIONS);
assert.strictEqual(grpcService.grpcMetadata, null);
assert.strictEqual(grpcService.grpcMetadata, fakeGrpcMetadata);
});

it('should create and localize grpcMetadata', function() {
Expand Down