-
Notifications
You must be signed in to change notification settings - Fork 1.2k
GAE (Flex_Java/Flex_Custom/Flex_Compat/Std_Java8), GCE, GKE testing app for gcj #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3069de5
Appengine tests
vam-google 10baa82
Merge remote-tracking branch 'upstream/master'
vam-google 35af49e
Appengine tests for https://github.com/GoogleCloudPlatform/google-clo…
vam-google 52908f9
Merge remote-tracking branch 'upstream/master'
vam-google 4307dff
Appengine tests for https://github.com/GoogleCloudPlatform/google-clo…
vam-google 75b4046
Appengine tests for https://github.com/GoogleCloudPlatform/google-clo…
vam-google 4ca6737
uncommented integration tests
vam-google 9b5e93d
Merge remote-tracking branch 'upstream/master'
vam-google f4fde11
Addressed code review comments. Removed testing apps from build by de…
vam-google 96e41c1
updated Dockerfile. Keeping this version update manual for now (not s…
vam-google 5ab123b
Uncommenting stuff in root pom.xml
vam-google e97f961
Automated updating versions in Dockerfiles.
vam-google 798ff0d
Changed thrown exception.
vam-google ed25adf
Merge remote-tracking branch 'upstream/master'
vam-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <parent> | ||
| <artifactId>google-cloud-pom</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>0.11.2-alpha-SNAPSHOT</version> | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
| <relativePath>../..</relativePath> | ||
| </parent> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
| <packaging>war</packaging> | ||
| <artifactId>google-cloud-appengine-flex-compat</artifactId> | ||
|
|
||
| <properties> | ||
| <appengine.sdk.version>1.9.51</appengine.sdk.version> | ||
| <jetty.maven.plugin>9.3.8.v20160314</jetty.maven.plugin> | ||
| <java.source.version>1.7</java.source.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>google-cloud-managed-test</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.appengine</groupId> | ||
| <artifactId>appengine-api-1.0-sdk</artifactId> | ||
| <version>${appengine.sdk.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <outputDirectory> | ||
| ${project.build.directory}/${project.build.finalName}/WEB-INF/classes | ||
| </outputDirectory> | ||
|
|
||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>${jetty.maven.plugin}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <version>3.3</version> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>${java.source.version}</source> | ||
| <target>${java.source.version}</target> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>com.google.appengine</groupId> | ||
| <artifactId>appengine-maven-plugin</artifactId> | ||
| <version>${appengine.sdk.version}</version> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> | ||
15 changes: 15 additions & 0 deletions
15
testing/google-cloud-appengine-flex-compat/src/main/webapp/WEB-INF/appengine-web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <appengine-web-app xmlns="http://appengine.google.com/ns/1.0"> | ||
| <application>vam-veneer</application> | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
| <service>flex-compat</service> | ||
| <version>1</version> | ||
| <threadsafe>true</threadsafe> | ||
| <!--<instance-class>B8</instance-class>--> | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
| <env>flex</env> | ||
| <beta-settings> | ||
| <setting name="enable_app_engine_apis" value="true"/> | ||
| </beta-settings> | ||
| <manual-scaling> | ||
| <instances>1</instances> | ||
| </manual-scaling> | ||
| </appengine-web-app> | ||
6 changes: 6 additions & 0 deletions
6
testing/google-cloud-appengine-flex-compat/src/main/webapp/WEB-INF/web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd" | ||
| version="3.1"> | ||
| </web-app> |
13 changes: 13 additions & 0 deletions
13
testing/google-cloud-appengine-flex-compat/src/main/webapp/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <html> | ||
| <title>google-cloud-java managed environments tests executor</title> | ||
| <body> | ||
| <p>Enter fully qualified test class names to execute. One class per line, use '#' for comments.</p> | ||
| <form method="POST" action="/test"> | ||
| <label> | ||
| <textarea name="classes" cols="50" rows="10">#com.google.cloud.storage.BlobIdTest</textarea> | ||
| </label> | ||
| <br/> | ||
| <input type="submit"/> | ||
| </form> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <parent> | ||
| <artifactId>google-cloud-pom</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>0.11.2-alpha-SNAPSHOT</version> | ||
| <relativePath>../..</relativePath> | ||
| </parent> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
| <packaging>war</packaging> | ||
| <artifactId>google-cloud-appengine-flex-custom</artifactId> | ||
|
|
||
| <properties> | ||
| <appengine.maven.plugin>1.2.1</appengine.maven.plugin> | ||
| <jetty.maven.plugin>9.3.8.v20160314</jetty.maven.plugin> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>google-cloud-managed-test</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <outputDirectory> | ||
| ${project.build.directory}/${project.build.finalName}/WEB-INF/classes | ||
| </outputDirectory> | ||
|
|
||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>${jetty.maven.plugin}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>com.google.cloud.tools</groupId> | ||
| <artifactId>appengine-maven-plugin</artifactId> | ||
| <version>${appengine.maven.plugin}</version> | ||
| <configuration> | ||
| <deploy.version>1</deploy.version> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
15 changes: 15 additions & 0 deletions
15
testing/google-cloud-appengine-flex-custom/src/main/appengine/app.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| runtime: custom | ||
| env: flex | ||
|
|
||
| handlers: | ||
| - url: /.* | ||
| script: this field is required, but ignored | ||
|
|
||
| service: flex-custom | ||
|
|
||
| manual_scaling: | ||
| instances: 1 | ||
|
|
||
| resources: | ||
| cpu: 1 | ||
| memory_gb: 6 |
2 changes: 2 additions & 0 deletions
2
testing/google-cloud-appengine-flex-custom/src/main/docker/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| FROM gcr.io/google_appengine/jetty | ||
| ADD google-cloud-appengine-flex-custom-0.10.1-alpha-SNAPSHOT.war $JETTY_BASE/webapps/root.war | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
6 changes: 6 additions & 0 deletions
6
testing/google-cloud-appengine-flex-custom/src/main/webapp/WEB-INF/web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd" | ||
| version="3.1"> | ||
| </web-app> |
13 changes: 13 additions & 0 deletions
13
testing/google-cloud-appengine-flex-custom/src/main/webapp/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <html> | ||
| <title>google-cloud-java managed environments tests executor</title> | ||
| <body> | ||
| <p>Enter fully qualified test class names to execute. One class per line, use '#' for comments.</p> | ||
| <form method="POST" action="/test"> | ||
| <label> | ||
| <textarea name="classes" cols="50" rows="10">#com.google.cloud.storage.BlobIdTest</textarea> | ||
| </label> | ||
| <br/> | ||
| <input type="submit"/> | ||
| </form> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <parent> | ||
| <artifactId>google-cloud-pom</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>0.11.2-alpha-SNAPSHOT</version> | ||
| <relativePath>../..</relativePath> | ||
| </parent> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
| <packaging>war</packaging> | ||
| <artifactId>google-cloud-appengine-flex-java</artifactId> | ||
|
|
||
| <properties> | ||
| <appengine.maven.plugin>1.2.1</appengine.maven.plugin> | ||
| <jetty.maven.plugin>9.3.8.v20160314</jetty.maven.plugin> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>google-cloud-managed-test</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <outputDirectory> | ||
| ${project.build.directory}/${project.build.finalName}/WEB-INF/classes | ||
| </outputDirectory> | ||
|
|
||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>${jetty.maven.plugin}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>com.google.cloud.tools</groupId> | ||
| <artifactId>appengine-maven-plugin</artifactId> | ||
| <version>${appengine.maven.plugin}</version> | ||
| <configuration> | ||
| <deploy.version>1</deploy.version> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
19 changes: 19 additions & 0 deletions
19
testing/google-cloud-appengine-flex-java/src/main/appengine/app.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| runtime: java | ||
| env: flex | ||
|
|
||
| runtime_config: # Optional | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
| jdk: openjdk8 | ||
| server: jetty9 | ||
|
|
||
| handlers: | ||
| - url: /.* | ||
| script: this field is required, but ignored | ||
|
|
||
| service: flex-java | ||
|
|
||
| manual_scaling: | ||
| instances: 1 | ||
|
|
||
| resources: | ||
| cpu: 1 | ||
| memory_gb: 6 | ||
6 changes: 6 additions & 0 deletions
6
testing/google-cloud-appengine-flex-java/src/main/webapp/WEB-INF/web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd" | ||
| version="3.1"> | ||
| </web-app> |
13 changes: 13 additions & 0 deletions
13
testing/google-cloud-appengine-flex-java/src/main/webapp/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <html> | ||
| <title>google-cloud-java managed environments tests executor</title> | ||
| <body> | ||
| <p>Enter fully qualified test class names to execute. One class per line, use '#' for comments.</p> | ||
| <form method="POST" action="/test"> | ||
| <label> | ||
| <textarea name="classes" cols="50" rows="10">#com.google.cloud.storage.BlobIdTest</textarea> | ||
| </label> | ||
| <br/> | ||
| <input type="submit"/> | ||
| </form> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <parent> | ||
| <artifactId>google-cloud-pom</artifactId> | ||
| <groupId>com.google.cloud</groupId> | ||
| <version>0.11.2-alpha-SNAPSHOT</version> | ||
| <relativePath>../..</relativePath> | ||
| </parent> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
| <packaging>war</packaging> | ||
| <artifactId>google-cloud-appengine-java8</artifactId> | ||
|
|
||
| <properties> | ||
| <appengine.sdk.version>1.9.51</appengine.sdk.version> | ||
| <jetty.maven.plugin>9.3.8.v20160314</jetty.maven.plugin> | ||
| <java.source.version>1.8</java.source.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>google-cloud-managed-test</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <outputDirectory> | ||
| ${project.build.directory}/${project.build.finalName}/WEB-INF/classes | ||
| </outputDirectory> | ||
|
|
||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>${jetty.maven.plugin}</version> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <version>3.3</version> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <source>${java.source.version}</source> | ||
| <target>${java.source.version}</target> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>com.google.appengine</groupId> | ||
| <artifactId>appengine-maven-plugin</artifactId> | ||
| <version>${appengine.sdk.version}</version> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
12 changes: 12 additions & 0 deletions
12
testing/google-cloud-appengine-java8/src/main/webapp/WEB-INF/appengine-web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <appengine-web-app xmlns="http://appengine.google.com/ns/1.0"> | ||
| <application>vam-veneer</application> | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
| <service>std-java8</service> | ||
| <version>1</version> | ||
| <runtime>java8</runtime> | ||
| <threadsafe>true</threadsafe> | ||
| <instance-class>B8</instance-class> | ||
| <manual-scaling> | ||
| <instances>1</instances> | ||
| </manual-scaling> | ||
| </appengine-web-app> | ||
6 changes: 6 additions & 0 deletions
6
testing/google-cloud-appengine-java8/src/main/webapp/WEB-INF/web.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd" | ||
| version="3.1"> | ||
| </web-app> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.