This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: allow users to call default service account endpoint if no email is passed#1687
Closed
harkamaljot wants to merge 6 commits intomainfrom
Closed
feat: allow users to call default service account endpoint if no email is passed#1687harkamaljot wants to merge 6 commits intomainfrom
harkamaljot wants to merge 6 commits intomainfrom
Conversation
sai-sunder-s
suggested changes
Mar 4, 2025
Contributor
Author
|
closing this pull request in favor of #1769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when we always fetch the email from the mds server and use that email to make an rpc call to mds server. However, this doesn't allow the user to call the default endpoint. So removing the update of the email after the call is made.
This is a safe change because in case when a email was specified by the user when making a cred object then mds server, return back same email, hence the current change doesn't effect this code path.
In case no email was specified, we call default service account endpoint, similar to other languages rather that updating the default with the email fetched from mds server. Both of these endpoints should return similar tokens in a normal case.
Tested the code on a GCE VM and verified the default path works as intended.