Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: optionally generate async rest and client files#2122

Merged
ohmayr merged 2 commits into
mainfrom
async-rest-initial
Sep 4, 2024
Merged

chore: optionally generate async rest and client files#2122
ohmayr merged 2 commits into
mainfrom
async-rest-initial

Conversation

@ohmayr

@ohmayr ohmayr commented Aug 31, 2024

Copy link
Copy Markdown
Contributor

This PR leverages the client settings to optionally generate the following files:

  • async_client.py if gRPC is a required as a transport or rest_async_io_enabled is True.
  • rest_asyncio.py if rest_async_io_enabled is True.

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Aug 31, 2024
@ohmayr ohmayr marked this pull request as ready for review September 3, 2024 14:18
@ohmayr ohmayr requested a review from a team September 3, 2024 14:18
@parthea parthea assigned ohmayr and unassigned parthea Sep 3, 2024
@ohmayr ohmayr force-pushed the async-rest-initial branch 2 times, most recently from dd34d55 to aa4bfa6 Compare September 3, 2024 20:35

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added non-blocking comment.

@ohmayr ohmayr merged commit bb7bac9 into main Sep 4, 2024
@ohmayr ohmayr deleted the async-rest-initial branch September 4, 2024 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants