fix: switch away from using "require" in benchmark used in tests#220
Merged
Conversation
nolanmar511
force-pushed
the
busybench-js
branch
2 times, most recently
from
f64a737 to
ab2343d
Compare
nolanmar511
changed the title
nolanmar511
force-pushed
the
busybench-js
branch
7 times, most recently
from
565647b to
bc0e8ef
Compare
amchiclet
approved these changes
Jun 8, 2022
Contributor
amchiclet
left a comment
amchiclet
left a comment
There was a problem hiding this comment.
Thanks for making this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before ignoring busybench.js in the linter config, I got the following error after this change:
I think since this file uses a separate package.json and contains a javascript file (and "gts" is meant to enforce typescript file), it seems reasonable to ignore it when running
gts checkfor this repo.Some additional changes were made along the way to make test easier to debug. I did run system_test.sh locally replacing the checks to confirm "busyLoop" appeared in the profile with checks for a different non-existent function and confirmed the test still failed.