Skip to content

chore(deps): update @types/node to v15#167

Merged
nolanmar511 merged 2 commits into
google:mainfrom
nolanmar511:update-node-types
May 25, 2021
Merged

chore(deps): update @types/node to v15#167
nolanmar511 merged 2 commits into
google:mainfrom
nolanmar511:update-node-types

Conversation

@nolanmar511
Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 commented May 25, 2021

A newer version of @types/node node is available. The type definition for the return type of process.memoryUsage was updated, so a few tests which stubbed this method also needed to be updated.

@nolanmar511 nolanmar511 mentioned this pull request May 25, 2021
@nolanmar511 nolanmar511 requested a review from wyk9787 May 25, 2021 23:09
Copy link
Copy Markdown
Contributor

@wyk9787 wyk9787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bit context on why tests are modified in PR description?

@nolanmar511 nolanmar511 merged commit 4c8f16b into google:main May 25, 2021
@nolanmar511 nolanmar511 deleted the update-node-types branch May 25, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants