docs(extensions): correct excludeTools examples that never match - #28966
docs(extensions): correct excludeTools examples that never match#28966samanyugoyal2010 wants to merge 1 commit into
Conversation
|
📊 PR Size: size/S
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request corrects misleading documentation and examples regarding the usage of the excludeTools property in extension manifests. It clarifies that this property only supports whole-tool exclusion and directs users to the policy engine for more granular command-level security restrictions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and examples to clarify that the excludeTools configuration matches whole tool names rather than supporting command-specific restrictions. It guides users to use the policy engine for restricting individual commands instead. There are no review comments, and I have no additional feedback to provide.
Note: Security Review has been skipped due to the limited scope of the PR.
Extension excludeTools entries are matched by exact tool name, so forms like run_shell_command(rm -rf *) never exclude anything. Update docs and the shipped example to use bare tool names, and point command-level blocking at the policy engine. Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
bf30784 to
841db3e
Compare
|
@dtedesco1 @dtedesco1-at-google can this PR Please be approved @niharnm can you please review this also and provide some feedback |
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
Extension excludeTools entries are matched by exact tool name, so forms like run_shell_command(rm -rf *) never exclude anything. Update docs and the shipped example to use bare tool names, and point command-level blocking at the policy engine.
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist