Skip to content

docs(extensions): correct excludeTools examples that never match - #28966

Open
samanyugoyal2010 wants to merge 1 commit into
google-gemini:mainfrom
samanyugoyal2010:cursor/correct-exclude-tools-examples-7117
Open

docs(extensions): correct excludeTools examples that never match#28966
samanyugoyal2010 wants to merge 1 commit into
google-gemini:mainfrom
samanyugoyal2010:cursor/correct-exclude-tools-examples-7117

Conversation

@samanyugoyal2010

Copy link
Copy Markdown

Extension excludeTools entries are matched by exact tool name, so forms like run_shell_command(rm -rf *) never exclude anything. Update docs and the shipped example to use bare tool names, and point command-level blocking at the policy engine.

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@samanyugoyal2010
samanyugoyal2010 requested review from a team as code owners August 22, 2026 19:33
@github-actions github-actions Bot added the size/s A small PR label Aug 22, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/S

  • Lines changed: 37
  • Additions: +25
  • Deletions: -12
  • Files changed: 3

@google-cla

google-cla Bot commented Aug 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request corrects misleading documentation and examples regarding the usage of the excludeTools property in extension manifests. It clarifies that this property only supports whole-tool exclusion and directs users to the policy engine for more granular command-level security restrictions.

Highlights

  • Clarified excludeTools behavior: Updated documentation to clarify that excludeTools matches whole tool names, correcting previous examples that suggested command-level filtering.
  • Recommended policy engine for command blocking: Added guidance to use the policy engine for blocking specific commands instead of attempting to use excludeTools.
  • Updated example configuration: Corrected the shipped example gemini-extension.json to use a valid tool name format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and examples to clarify that the excludeTools configuration matches whole tool names rather than supporting command-specific restrictions. It guides users to use the policy engine for restricting individual commands instead. There are no review comments, and I have no additional feedback to provide.

Note: Security Review has been skipped due to the limited scope of the PR.

Extension excludeTools entries are matched by exact tool name, so forms like
run_shell_command(rm -rf *) never exclude anything. Update docs and the
shipped example to use bare tool names, and point command-level blocking at
the policy engine.

Co-authored-by: samanyugoyal2010 <samanyugoyal2010@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/correct-exclude-tools-examples-7117 branch from bf30784 to 841db3e Compare August 22, 2026 19:39
@gemini-cli gemini-cli Bot added the priority/p1 Important and should be addressed in the near term. label Aug 22, 2026
@samanyugoyal2010

samanyugoyal2010 commented Aug 22, 2026

Copy link
Copy Markdown
Author

@dtedesco1 @dtedesco1-at-google can this PR Please be approved

@niharnm can you please review this also and provide some feedback

@gemini-cli

gemini-cli Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term. size/s A small PR status/pr-nudge-sent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant