Skip to content

fix: dedupe home agent directories - #27694

Closed
he-yufeng wants to merge 1 commit into
google-gemini:mainfrom
he-yufeng:fix/dedupe-home-agent-dirs
Closed

fix: dedupe home agent directories#27694
he-yufeng wants to merge 1 commit into
google-gemini:mainfrom
he-yufeng:fix/dedupe-home-agent-dirs

Conversation

@he-yufeng

Copy link
Copy Markdown

Fixes #27692.

Summary

  • deduplicate project-level and user-level agent directories before loading local agents
  • keep project/user precedence unchanged when the directories are different
  • add a regression test for the home-directory workspace case where both paths resolve to ~/.gemini/agents

To verify

  • npm exec -- vitest run packages/core/src/agents/registry.test.ts
  • npm run typecheck --workspace @google/gemini-cli-core
  • npm exec -- eslint packages/core/src/agents/registry.ts packages/core/src/agents/registry.test.ts --max-warnings 0
  • git diff --check HEAD~1..HEAD

@he-yufeng
he-yufeng requested a review from a team as a code owner June 5, 2026 12:32
@github-actions github-actions Bot added the size/m A medium sized PR label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

📊 PR Size: size/M

  • Lines changed: 55
  • Additions: +53
  • Deletions: -2
  • Files changed: 2

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality labels Jun 5, 2026
@gemini-cli

gemini-cli Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@he-yufeng

Copy link
Copy Markdown
Author

Closing this myself to stay within the repository's open-PR limit. The newer web-search timeout fix is tied to a P1 issue and looks higher priority than this home-directory dedupe change right now. This branch stays in my fork if maintainers want to revisit it later.

@he-yufeng he-yufeng closed this Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release. size/m A medium sized PR status/pr-nudge-sent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate agent name warning when running Gemini CLI from the user's home directory

1 participant