Fix #18834: use docker inspect exit code instead of stdout parsing - #27428
Fix #18834: use docker inspect exit code instead of stdout parsing#27428LifeJiggy wants to merge 1 commit into
Conversation
gemini-cli
Bot
added
priority/p1
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the sandbox image existence check by switching from parsing command output to checking the exit code of the Docker inspection command. This ensures that the system correctly identifies image presence even when environment variables like DOCKER_BUILDKIT are enabled, which previously caused output to be redirected to stderr and triggered unnecessary image pulls. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the imageExists utility in packages/cli to use docker inspect --type=image instead of docker images -q for checking the existence of a sandbox image. The implementation now relies on the process exit code rather than parsing stdout, and includes stdio: 'ignore' to suppress output. Corresponding test mocks and assertions in sandbox.test.ts have been updated to reflect these changes. I have no feedback to provide as there were no review comments to evaluate.
8bc9dba to
9e19863
Compare
|
@scidomino, @abhipatel12 , @bbiggs PTAL |
9e19863 to
13facc0
Compare
|
Please do not ping individual maintainers. Our inboxes are overfull and many of us have been assigned to other project. I appreciate that it's frustrating but this will be reviewed by the normal process or not at all. |
|
Understood. I apologize for pinging multiple maintainers. I won't ping individuals again and will respect the normal review process going forward. Thank you. |
13facc0 to
04fcc1f
Compare
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
…ut parsing The old implementation parsed stdout from docker images -q which could produce false negatives when Docker outputs image names to stderr (e.g. with DOCKER_BUILDKIT). Switch to docker inspect --type=image and check exit code directly. Also update all test mocks to match the new args and remove now-unused stdout data emission.
04fcc1f to
7a0353a
Compare
|
📊 PR Size: size/M
|
|
Friendly ping here. this PR now have 1 approval please let this pass through before the bot automatically close it @ALL PTAL |
|
/gemini help |
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
this hurt that depsite trying to saved this PR and requesting for review now its closed. |
|
Hi [Recipient Name],
I am writing to share an update regarding Pull Request #27428, "Fix #18834:
use docker inspect exit code instead of stdout parsing."
The gemini-cli[bot] has officially closed this PR. Following an initial
warning issued on June 2nd, the bot finalized the closure because the PR
remained open for 14 days without receiving a "help wanted" designation.
This aligns with the current repository policy which prioritizes review and
consideration for issues explicitly labeled as such.
On June 8th, ArkhAngelLifeJiggy pushed a final commit and noted that the PR
had already received one approval. Despite requests for a final review to
prevent the automated closure, the bot proceeded as scheduled.
ArkhAngelLifeJiggy has expressed disappointment that the contribution was
closed despite these active efforts to save the PR.
Please let me know if we should take any further action or if you would
like to discuss the status of this fix.
Best regards,
MUH SHINAN
…On Tue, 9 Jun, 2026, 11:07 am ArkhAngelLifeJiggy, ***@***.***> wrote:
*LifeJiggy* left a comment (google-gemini/gemini-cli#27428)
<#27428 (comment)>
**scidomino <http:///scidomino> ** commente
this hurt that depsite trying to saved this PR and requesting for review
now its closed.
—
Reply to this email directly, view it on GitHub
<#27428?email_source=notifications&email_token=ASRK752FC4R44NLMSUO6NET4655PRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRVGU3DINRQHAY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4655646081>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASRK756V3MBJMA2MTMQ4JNT4655PRAVCNFSM6AAAAACZLW4JEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNJVGY2DMMBYGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@sin325 @gemini-cli-bot Hey team, This PR (#27428) already had 1 approval and I pushed a final commit on June 8th to address feedback. I understand the 14-day policy, but it feels a bit harsh to close a PR that was actively being worked on and had maintainer approval. Can we reopen this PR so it can get a final review and be merged? It fixes #18834 and already received approval. Happy to make any additional changes needed. Thanks! |
|
Hi @LifeJiggy , I'm not a maintainer but I reviewed your fix because I am impacted by the issue #18834. I think the bot there wants someone to retest with the latest version to see if the issue persists. Can you do that? Maybe the correct process is to convince the bot that the issue is valid and it will label it with Thanks for your efforts. |
|
Thanks for taking the time to review and for the feedback. I already retested this fix recently (June 8th push) with the latest main branch and it resolves the issue cleanly (using The PR had 1 approval before the bot closed it. Would really appreciate if a maintainer could reopen it for final review. @sin325 Any chance we can get this reopened? Happy to address any remaining feedback. Thanks! |
4 participants
Summary
Fix sandbox imageExists returning false negatives when Docker outputs image names to stderr (e.g. with DOCKER_BUILDKIT). Switch from parsing docker images -q stdout to using docker inspect --type=image exit code.
Details
docker images -q may write the image name to stderr when DOCKER_BUILDKIT=1 is set, causing the old stdout-based parsing to return a false negative. The sandbox would then attempt to pull the image unnecessarily. The fix uses docker inspect --type=image and checks the exit code, which is reliable regardless of output channel.
Related Issues
Fixes #18834
How to Validate
Pre-Merge Checklist