AgentLoopContext is incompatible with Config type

[mini2s]

What happened?

AgentLoopContext is incompatible with Config type

export async function deleteSession(
  config: Config,
  sessionIndex: string,
): Promise<void> {
  .....
  try {
    // Use ChatRecordingService to delete the session
    const chatRecordingService = new ChatRecordingService(config);
    chatRecordingService.deleteSession(sessionToDelete.file);

    const time = formatRelativeTime(sessionToDelete.lastUpdated);
    writeToStdout(
      `Deleted session ${sessionToDelete.index}: ${sessionToDelete.firstUserMessage} (${time})`,
    );
  } catch (error) {
    writeToStderr(
      `Failed to delete session: ${error instanceof Error ? error.message : 'Unknown error'}`,
    );
  }
}

export class ChatRecordingService {
  private conversationFile: string | null = null;
  private cachedLastConvData: string | null = null;
  private cachedConversation: ConversationRecord | null = null;
  private sessionId: string;
  private projectHash: string;
  private kind?: 'main' | 'subagent';
  private queuedThoughts: Array<ThoughtSummary & { timestamp: string }> = [];
  private queuedTokens: TokensSummary | null = null;
  private context: AgentLoopContext;

  constructor(context: AgentLoopContext) {
    this.context = context;
    this.sessionId = context.promptId;
    this.projectHash = getProjectHash(context.config.getProjectRoot());
  }
  .....
}

What did you expect to happen?

Fix ChatRecordingService initialization error

Client information

Client Information

Run gemini to enter the interactive CLI, then run the /about command.

> /about
# paste output here

Login information

No response

Anything else we need to know?

No response

[SupunGeethanjana]

Implementation Plan: Fix ChatRecordingService constructor type mismatch

Problem

packages/cli/src/utils/sessions.ts:99 calls new ChatRecordingService(config) where config is Config, but the constructor in packages/core/src/services/chatRecordingService.ts expects AgentLoopContext. This compiles (possibly with the cast seen in the reproduce file) but will fail at runtime because:

• The constructor accesses context.promptId (doesn't exist on Config)
• deleteSession accesses this.context.config.storage.getProjectTempDir() — but this.context would be the Config itself, not wrapped in AgentLoopContext

Root Cause

deleteSession was added to ChatRecordingService as a convenience, but the class is designed around an active agent session (AgentLoopContext). Session deletion is a management operation that only needs Config (specifically config.storage.getProjectTempDir()).

Proposed Fix: Extract a static deleteSessionFiles method

Why this approach:

• Minimal change — touches only 2 files
• No need to mock/construct a fake AgentLoopContext
• The static method contains no new logic — it just de-instances the existing private helpers by passing tempDir explicitly (they already do this)
• The existing instance deleteSession() can delegate to the static version

Changes

1. packages/core/src/services/chatRecordingService.ts

Add a static deleteSessionFiles(config: Config, sessionIdOrBasename: string): void method that:

• Calls config.storage.getProjectTempDir() directly
• Reuses the existing deriveShortId and getMatchingSessionFiles logic (converted to static private helpers, or inlined)
• Calls the existing deleteSessionAndArtifacts logic

The existing instance method deleteSession() becomes a one-liner delegating to the static:

deleteSession(sessionIdOrBasename: string): void {
  ChatRecordingService.deleteSessionFiles(this.context.config, sessionIdOrBasename);
}

2. packages/cli/src/utils/sessions.ts

Replace:

const chatRecordingService = new ChatRecordingService(config);
chatRecordingService.deleteSession(sessionToDelete.file);

With:

ChatRecordingService.deleteSessionFiles(config, sessionToDelete.file);

Files Changed

File | Change -- | -- packages/core/src/services/chatRecordingService.ts | Add static deleteSessionFiles(config, id), refactor instance deleteSession to delegate to it; make private helpers static packages/cli/src/utils/sessions.ts | Call static method instead of constructing an instance

No changes needed to

• Exports (ChatRecordingService is already exported)
• Tests for the normal instance usage (unaffected)
• sessionCleanup.ts (uses a different path)

---

[cocosheng-g]

Triage Summary

This is a clear bug report regarding a type mismatch and initialization error when deleting sessions. The community has provided a clean architectural fix in PR #22981 by extracting a static deleteSessionFiles method. Categorized as Help-wanted.

@SupunGeethanjana, apologies! It looks like your PR #22981 was incorrectly closed by our bot. I have reopened it and assigned this issue to you. Would you like to continue working on it?

[SupunGeethanjana]

Triage Summary

This is a clear bug report regarding a type mismatch and initialization error when deleting sessions. The community has provided a clean architectural fix in PR #22981 by extracting a static deleteSessionFiles method. Categorized as Help-wanted.

@SupunGeethanjana, apologies! It looks like your PR #22981 was incorrectly closed by our bot. I have reopened it and assigned this issue to you. Would you like to continue working on it?

@cocosheng-g Yes I have opened new PR for this #25097