Fix softmax_cross_entropy to handle -inf logits correctly when corresponding label is 0. - #898
Merged
copybara-service[bot] merged 1 commit intoApr 7, 2024
Merged
Conversation
Member
|
Would perhaps using logsumexp (https://jax.readthedocs.io/en/latest/_autosummary/jax.scipy.special.logsumexp.html) be a solution here? Also, please add tests :-) |
Contributor
Author
|
@fabianp Added tests.
|
…ponding label is 0.
7 tasks
vroulet
approved these changes
Apr 5, 2024
Merged
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Added tests for correct gradient evaluations. PiperOrigin-RevId: 622956379
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Added tests for correct gradient evaluations. PiperOrigin-RevId: 622956379
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Added tests for correct gradient evaluations. PiperOrigin-RevId: 623180578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#896