Fix sign discrepancy in tolerance in scale_by_backtracking_linesearch - #853
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_613580822
branch
2 times, most recently
from
March 7, 2024 16:26
eef6f66 to
a5ccd0a
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_613580822
branch
from
March 7, 2024 17:29
a5ccd0a to
603e3d8
Compare
the tolerance should be (1 + \delta) instead of (1 - \delta) PiperOrigin-RevId: 613613682
copybara-service
Bot
force-pushed
the
test_613580822
branch
from
March 7, 2024 17:42
603e3d8 to
de46234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sign discrepancy in tolerance in scale_by_backtracking_linesearch
the tolerance should be (1 + \delta) instead of (1 - \delta)