adding additional non 2d array test in galore (refrence to #1541) - #1574
Merged
Conversation
6 tasks
vroulet
reviewed
Jan 23, 2026
vroulet
left a comment
vroulet
left a comment
Collaborator
There was a problem hiding this comment.
Sorry I missed something. Can you fix it please?
| from optax._src import transform | ||
| from optax._src import update | ||
| from optax.contrib import _galore | ||
| import optax |
Collaborator
There was a problem hiding this comment.
You should not need to make this general "optax" import. Try importing adequate subpackages
Collaborator
There was a problem hiding this comment.
Nevermind I'll take care of it internally.
copybara-service
Bot
merged commit Jan 23, 2026
29de45a
into
google-deepmind:main
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding the additional tests for the galore optimizer as determined in the pr #1541