Skip to content

Optional auxiliary learning rate for Adam within Moun - #1565

Merged
copybara-service[bot] merged 2 commits into
google-deepmind:mainfrom
RaphaelRe:aux-lr-adam-muon
Jan 16, 2026
Merged

Optional auxiliary learning rate for Adam within Moun#1565
copybara-service[bot] merged 2 commits into
google-deepmind:mainfrom
RaphaelRe:aux-lr-adam-muon

Conversation

@RaphaelRe

Copy link
Copy Markdown
Contributor

#1563
This PR adds an option for an additional learning rate for the tree leaves that are handled by Adam(W) in the Muon API.

I also added a line to highlight, that the API uses AdamW (and not Adam) under the hood with a weight decay of 0. A minor thing, but may impact performance if one is not aware of it while using a positive weight decay for Adam. This is not directly written in the docstrings and can only be seen either in the code or in the contrib examples.

@google-cla

google-cla Bot commented Jan 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rdyro

rdyro commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Great, thank you!

I think you need to sign the contributor agreement (CLA), but I can merge then

@RaphaelRe

RaphaelRe commented Jan 16, 2026

Copy link
Copy Markdown
Contributor Author

Yep. Forgot this. Should be signed now.
Maybe you can rerun the check if necessary.

@RaphaelRe

Copy link
Copy Markdown
Contributor Author

Sorry, it looks like there was a delay with the agreement or I missed something. Now the CLA is checked as signed.

@rdyro

rdyro commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Can you try to force push or push an empty commit? I think this should refresh the github CI

@RaphaelRe

Copy link
Copy Markdown
Contributor Author

Made an empty commit. Maybe you can resolve it now.
If not, I can make a new pull request.
Sorry for the issue. The next time, I will be a bit more patient. Promised 😅

@rdyro

rdyro commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

No worries, thanks for the PR :)

@copybara-service
copybara-service Bot merged commit 78d9c0c into google-deepmind:main Jan 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants