Simplify l2 projection - #1394
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_788081175
branch
3 times, most recently
from
July 28, 2025 19:01
6bb02e8 to
3dafd06
Compare
Previous code ensured that grad(proj_l2ball)(0.0, 1.0) would not be nan. Present code keeps that behavior but with a simpler approach (the problem was the derivative of the square root, taking the square root after maximum solves the problem). PiperOrigin-RevId: 788106306
copybara-service
Bot
force-pushed
the
test_788081175
branch
from
July 28, 2025 19:10
3dafd06 to
8c9a619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify l2 projection
Previous code ensured that grad(proj_l2ball)(0.0, 1.0) would not be nan.
Present code keeps that behavior but with a simpler approach (the problem was the derivative of the square root, taking the square root after maximum solves the problem).