Add improved version of Hungarian algorithm.

[carlosgmartin]

Follow-up to #1083 (comment).

[vroulet]

Thanks again @carlosgmartin!
Some suggestions:

• keep a single file, and name the first algorithm you did as "base_hungarian_algorithm"
• add in e.g. the new algorithm's docstring a sentence that differentiates the two implementations.
• Add a test that compares the results between the two implementations maybe

Otherwise it's great

[carlosgmartin]

@vroulet Seems to me it’s cleaner to keep each implementation in a separate file, since

1. It keeps the implementations less entangled and keeps their respective helper functions separate, avoiding potential confusion.
2. It keeps the modules shorter/less crowded, especially if more implementations are added in the future.

WDYT?

[vroulet]

It keeps the implementations less entangled and keeps their respective helper functions separate, avoiding potential confusion.

In any case we should add in the docstring why they differ.

It keeps the modules shorter/less crowded, especially if more implementations are added in the future.

I would actually agree with you, but typically the alias file in optax has an ever increasing list of optimizers. So let's keep the same logic here. (That would actually be my main argument in favor of keeping them in a single file: it may be better for the package to follow a similar philosophy across folders/files).

[carlosgmartin]

@vroulet Done.

[vroulet]

Thanks again @carlosgmartin !