Skip to content

Fixed [Bug] Marshal crashed #546 - #547

Open
Shobhitdimri01 wants to merge 1 commit into
goccy:masterfrom
Shobhitdimri01:issue-546
Open

Fixed [Bug] Marshal crashed #546#547
Shobhitdimri01 wants to merge 1 commit into
goccy:masterfrom
Shobhitdimri01:issue-546

Conversation

@Shobhitdimri01

@Shobhitdimri01 Shobhitdimri01 commented Apr 21, 2025

Copy link
Copy Markdown
  • Code crash (Panic) due to unexpected fault address 0x9a5a5aaaaa656666 with change in order of struct fixed
  • Fixed code by adding deepcopy and validating unexported weirdness
  • Enhanced function getFilteredCodeSetIfNeeded inside compiler.go module to handle nil pointer or interface, likely occurring during serialization.

@goccy

goccy commented Nov 8, 2025

Copy link
Copy Markdown
Owner

@Shobhitdimri01
Doing a deep copy here may significantly degrade performance. Please run a benchmark and report the results. Also, I'd like to see the CI results, so could you make another commit?

@Shobhitdimri01

Shobhitdimri01 commented Nov 8, 2025 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants