Add units to team by lunny · Pull Request #947 · go-gitea/gitea

lunny · 2017-02-15T14:25:56Z

This PR allows you create one team who can only see issues or pull request or wikis.

lunny · 2017-04-27T05:59:27Z

This is done and could be reviewed. When add/edit a team on organization, you could chose which units could be organization's repositories operated on the by this team. For example, we can define tester team which can only operate issues on all repositories the tester team could visit.

bkcsoft

Few comments

bkcsoft · 2017-04-28T14:29:45Z

Do we really need External as a separate unit? Can we enable both internal wiki and external wiki at the same time? (same for Tracker)

I think yes. Yes, we can.

bkcsoft · 2017-04-28T14:30:33Z

Same as above

bkcsoft · 2017-04-28T14:30:44Z

same as above

bkcsoft · 2017-04-28T14:34:15Z

Why are we leaking information that this repo exists but have nothing to show? IMO no valid Units should be the same as Private.

The error message is only for log. The UI will only show 404.

bkcsoft · 2017-04-28T14:35:00Z

Why was this moved?

Move this for easy add middleware contex.CheckUnit. Before this, releases URLs are put on many places.

bkcsoft · 2017-04-28T23:20:47Z

LGTM

sapk · 2017-05-18T08:53:45Z

Not an expert in xorm but can't .Where("1=1") be removed ?

sapk · 2017-05-18T09:12:53Z

This need rebase.
I will try to test it but looking at code, I could give my trusted LGTM.

lunny · 2017-05-18T09:41:16Z

@sapk rebased

kubatyszko · 2017-07-31T22:27:23Z

I know this PR is closed, but I believe I found an issue that might be related.
In my installation, SOME repos can't browse source, opening the repo (even clicking on <>code) redirects to /releases.

I think this PR modified a lot of routes related to releases, I wonder if that has anything to do with it...

lunny · 2017-08-01T02:36:27Z

@kubatyszko could you post an issue to describe that?

lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review labels Feb 15, 2017

lunny added this to the 1.2.0 milestone Feb 15, 2017

This was referenced Mar 10, 2017

Seperate the issue management and wiki as 'plugins' #1169

Closed

Finer permission controls for users to prevent spam #1228

Open

lunny force-pushed the lunny/team_units branch from c534a7f to 3e23400 Compare March 19, 2017 02:22

lunny force-pushed the lunny/team_units branch from 3e23400 to e593669 Compare April 27, 2017 05:56

lunny removed the pr/wip This PR is not ready for review label Apr 27, 2017

lunny changed the title ~~[WIP] Add units to team~~ Add units to team Apr 27, 2017

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2017

bkcsoft suggested changes Apr 28, 2017

View reviewed changes

bkcsoft approved these changes Apr 28, 2017

View reviewed changes

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2017

lunny force-pushed the lunny/team_units branch 2 times, most recently from e2da2af to 299b4e9 Compare May 4, 2017 08:01

lunny force-pushed the lunny/team_units branch from b4483e7 to dd65714 Compare May 15, 2017 15:07

sapk reviewed May 18, 2017

View reviewed changes

tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2017

lunny added 7 commits May 18, 2017 17:36

add units to team

6db69dd

fix lint

7759020

finish team setting backend

931ded1

finished permission controll on routes

1ca4810

fix import blank line

1cbf72b

add unit check on ssh/http pull and push and fix test failed

9827bb5

fix fixtures data

90972f1

remove unused code

7d29013

lunny force-pushed the lunny/team_units branch from dd65714 to 7d29013 Compare May 18, 2017 09:41

lunny merged commit fd6034a into go-gitea:master May 18, 2017

lunny deleted the lunny/team_units branch May 18, 2017 14:56

wyattoday mentioned this pull request May 18, 2017

Pull request #947 breaks HTTPS push/pull to "master" when logged in as Admin #1751

Closed

7 tasks

lunny added a commit to lunny/gitea that referenced this pull request May 19, 2017

fix admin lost permission caused by go-gitea#947

6362462

bkcsoft added a commit that referenced this pull request May 19, 2017

fix admin lost permission caused by #947 (#1753)

281a038

trebonian mentioned this pull request May 20, 2017

Fixes to #947 broke ssh access to repositories #1771

Closed

5 tasks

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Uh oh!

Uh oh!

Conversation

lunny commented Feb 15, 2017

Uh oh!

lunny commented Apr 27, 2017

Uh oh!

bkcsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkcsoft commented Apr 28, 2017

Uh oh!

sapk May 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sapk commented May 18, 2017

Uh oh!

lunny commented May 18, 2017

Uh oh!

kubatyszko commented Jul 31, 2017

Uh oh!

lunny commented Aug 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sapk May 18, 2017 •

edited

Loading