Skip to content

feat(actions): show run status on browser tab favicon - #38071

Merged
bircni merged 7 commits into
go-gitea:mainfrom
bircni:action-icon
Jun 15, 2026
Merged

feat(actions): show run status on browser tab favicon#38071
bircni merged 7 commits into
go-gitea:mainfrom
bircni:action-icon

Conversation

@bircni

@bircni bircni commented Jun 11, 2026

Copy link
Copy Markdown
Member
  • Show GitHub-style action run status on the browser tab favicon when viewing an Actions run detail page (RepoActionView)

  • Extract shared status→icon mapping

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2026
@github-actions github-actions Bot added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 11, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 11, 2026
Comment thread web_src/js/modules/favicon-status.ts Outdated
Comment thread web_src/js/modules/favicon-status.ts Outdated
Comment thread web_src/js/modules/favicon-status.ts Outdated
Comment thread web_src/js/modules/favicon-status.ts Outdated
Comment thread web_src/js/modules/favicon-status.ts Outdated
Comment thread web_src/js/components/RepoActionView.vue Outdated
@bircni
bircni requested a review from wxiaoguang June 13, 2026 11:14
syncActionRunFavicon('running');
for (const link of links) {
expect(link.href).toMatch(/^data:image\/svg\+xml,/);
expect(decodeURIComponent(link.href)).toContain('M3.05 3.05');

@wxiaoguang wxiaoguang Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike such unmaintainable tests.

You can use some hidden elements to contain the status name, or if it is possible just use <svg data-actions-status-name=....>


I won't block it if it looks good to others.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

bircni added 2 commits June 14, 2026 21:06
Add data-actions-status-name to the favicon badge so tests can verify
the embedded status icon by a stable marker rather than brittle svg
path data.

Assisted-by: Claude:claude-opus-4-8
@bircni bircni added this to the 1.27.0 milestone Jun 14, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 15, 2026
@bircni
bircni merged commit bce6df2 into go-gitea:main Jun 15, 2026
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 15, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request Jun 17, 2026
* origin/main: (39 commits)
  [skip ci] Updated translations via Crowdin
  fix(mssql): expand legacy issue and comment long-text columns (go-gitea#38120)
  fix(deps): update npm dependencies (go-gitea#38137)
  ci: trigger giteabot maintenance on main pushes (go-gitea#38135)
  [skip ci] Updated translations via Crowdin
  chore(deps): update module github.com/go-swagger/go-swagger to v0.34.1 (go-gitea#38122)
  fix(pull): preserve squash message trailers and additional commit messages (go-gitea#37954)
  fix(packages): validate module version in goproxy ParsePackage (go-gitea#38104)
  feat: add raw diff/patch endpoint for repository comparisons (go-gitea#37632)
  chore(deps): update pnpm to v11.5.3 (go-gitea#38133)
  chore(deps): update action dependencies (go-gitea#38121)
  docs: update missed gov docs update (go-gitea#38131)
  fix(deps): update npm dependencies (go-gitea#38123)
  chore(deps): update dependency djlint to v1.39.0 (go-gitea#38124)
  feat(actions): show run status on browser tab favicon (go-gitea#38071)
  chore: center info message for unsupported jupyter notebook versions (go-gitea#38114)
  chore(actions): Add icon for status filter (go-gitea#38082)
  feat(org): add team visibility so org members can discover teams (go-gitea#37680)
  chore(deps): bump dockerfile to use Alpine 3.24 (go-gitea#38077)
  chore: fix form string abuse (go-gitea#38106)
  ...

# Conflicts:
#	package.json
#	pnpm-lock.yaml
zeekay pushed a commit to hanzoai/forge that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants