feat(actions): show run status on browser tab favicon - #38071
Merged
Conversation
lunny
approved these changes
Jun 11, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 12, 2026
wxiaoguang
reviewed
Jun 13, 2026
| syncActionRunFavicon('running'); | ||
| for (const link of links) { | ||
| expect(link.href).toMatch(/^data:image\/svg\+xml,/); | ||
| expect(decodeURIComponent(link.href)).toContain('M3.05 3.05'); |
Contributor
There was a problem hiding this comment.
I really dislike such unmaintainable tests.
You can use some hidden elements to contain the status name, or if it is possible just use <svg data-actions-status-name=....>
I won't block it if it looks good to others.
Add data-actions-status-name to the favicon badge so tests can verify the embedded status icon by a stable marker rather than brittle svg path data. Assisted-by: Claude:claude-opus-4-8
wxiaoguang
approved these changes
Jun 15, 2026
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 17, 2026
* origin/main: (39 commits) [skip ci] Updated translations via Crowdin fix(mssql): expand legacy issue and comment long-text columns (go-gitea#38120) fix(deps): update npm dependencies (go-gitea#38137) ci: trigger giteabot maintenance on main pushes (go-gitea#38135) [skip ci] Updated translations via Crowdin chore(deps): update module github.com/go-swagger/go-swagger to v0.34.1 (go-gitea#38122) fix(pull): preserve squash message trailers and additional commit messages (go-gitea#37954) fix(packages): validate module version in goproxy ParsePackage (go-gitea#38104) feat: add raw diff/patch endpoint for repository comparisons (go-gitea#37632) chore(deps): update pnpm to v11.5.3 (go-gitea#38133) chore(deps): update action dependencies (go-gitea#38121) docs: update missed gov docs update (go-gitea#38131) fix(deps): update npm dependencies (go-gitea#38123) chore(deps): update dependency djlint to v1.39.0 (go-gitea#38124) feat(actions): show run status on browser tab favicon (go-gitea#38071) chore: center info message for unsupported jupyter notebook versions (go-gitea#38114) chore(actions): Add icon for status filter (go-gitea#38082) feat(org): add team visibility so org members can discover teams (go-gitea#37680) chore(deps): bump dockerfile to use Alpine 3.24 (go-gitea#38077) chore: fix form string abuse (go-gitea#38106) ... # Conflicts: # package.json # pnpm-lock.yaml
zeekay
pushed a commit
to hanzoai/forge
that referenced
this pull request
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show GitHub-style action run status on the browser tab favicon when viewing an Actions run detail page (
RepoActionView)Extract shared status→icon mapping