Support selecting theme on the footer - #35741
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
Contributor
Author
|
wxiaoguang
force-pushed
the
support-theme-select
branch
3 times, most recently
from
October 24, 2025 17:29
73de799 to
af7cbfd
Compare
wxiaoguang
force-pushed
the
support-theme-select
branch
from
October 24, 2025 17:46
af7cbfd to
e884b35
Compare
lunny
approved these changes
Oct 24, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
changed the title
Member
|
Maybe there is a better colorblind icon, like "eye with cross"? If not deemed ok, I would at least make the white part of the current icon transparent, it looks odd on dark theme. |
silverwind
reviewed
Oct 27, 2025
silverwind
reviewed
Oct 27, 2025
Contributor
Author
I have thought about "eye with cross", but it reads like "blind" or "closed eyes". This icon is from GitHub: Details
And use transparent background: d567924 |
silverwind
reviewed
Oct 28, 2025
silverwind
approved these changes
Oct 28, 2025
GiteaBot
added
lgtm/done
Member
|
A nice enhancement here would be to make it work without a page reload, e.g. send the theme change to backend in an fetch call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27576