Restricting access to fork functioanlity to users with Code access

[jonasfranz]

Actual situation: Users how do not have access to UnitTypeCode can create a fork of the repository and gain access to the code.

This fixes this problem by restiricting access to the fork functionality to users with UnitTypeCode.

[codecov-io]

Codecov Report

Merging #2534 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #2534   +/-   ##
=======================================
  Coverage   26.96%   26.96%           
=======================================
  Files          84       84           
  Lines       16906    16906           
=======================================
  Hits         4559     4559           
  Misses      11672    11672           
  Partials      675      675

Impacted Files	Coverage Δ
models/repo.go	13.53% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6533f...6f744f7. Read the comment docs.

[ethantkoenig]

Why are these changes to RepoAssignment() necessary? It seems to me that adding the context.LoadRepoUnits() and context.CheckUnit(models.UnitTypeCode) handlers should be sufficient (along with the changes to repo.CanBeForked())

[lunny]

I think it needs load repo because context.LoadRepoUnits() needs ctx.Reop to context but fork's route only has reopid no repopath.

[ethantkoenig]

Good catch, you're right.

But since we only need to load ctx.Repo, maybe it would be better to add a separate handler for loading :repoid, instead of making RepoAssignment() more complicated by adding a big if/else?

[lunny]

@ethantkoenig I agree with you to make a new middleware to do that but not change ReopAssignment

[jonasfranz]

@lafriks I think kind/security might also fit because of the illegal access to code.

[lunny]

LGTM

[lafriks]

LGTM

[appleboy]

LGTM

[lunny]

@JonasFranzDEV please send a back port to v1.2

[jonasfranz]

@lunny Done (#2542)