Skip to content

Improve swagger doc - #2274

Merged
lafriks merged 9 commits into
go-gitea:masterfrom
sapk-fork:improve-swagger-doc
Aug 21, 2017
Merged

Improve swagger doc#2274
lafriks merged 9 commits into
go-gitea:masterfrom
sapk-fork:improve-swagger-doc

Conversation

@sapk

@sapk sapk commented Aug 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

All is in the title

Need go-gitea/go-sdk#67

@lunny lunny added this to the 1.3.0 milestone Aug 7, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Aug 7, 2017
@sapk sapk changed the title [WIP] Improve swagger doc (path: /admin) [WIP] Improve swagger doc Aug 7, 2017
@sapk
sapk force-pushed the improve-swagger-doc branch 4 times, most recently from 32615c9 to f66e0ef Compare August 8, 2017 00:22
@sapk sapk changed the title [WIP] Improve swagger doc Improve swagger doc Aug 8, 2017
@sapk sapk mentioned this pull request Aug 8, 2017
Merged
@sapk

sapk commented Aug 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is just comments, so it could make it in 1.2.0 without effect.

Edit: This will update sdk package that added issue_tracked_time.go but I don't think this will have a big impact.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 8, 2017
@sapk
sapk force-pushed the improve-swagger-doc branch 2 times, most recently from 38985dd to 8af5096 Compare August 20, 2017 18:43
@appleboy

appleboy commented Aug 21, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 21, 2017
@lunny

lunny commented Aug 21, 2017

Copy link
Copy Markdown
Member

@sapk if it's in time, I will move this to v1.2

@sapk

sapk commented Aug 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

@lunny I updated go-gitea/go-sdk#67. I will sync this when sdk is merged.

@lunny

lunny commented Aug 21, 2017

Copy link
Copy Markdown
Member

@sapk go-gitea/go-sdk#67 merged.

@sapk
sapk force-pushed the improve-swagger-doc branch from 8af5096 to a9d5646 Compare August 21, 2017 10:48
@sapk

sapk commented Aug 21, 2017

Copy link
Copy Markdown
Member Author

sdk updated and swagger re-generated.
PR is ready to be merged

@lafriks

lafriks commented Aug 21, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2017
@lafriks lafriks modified the milestones: 1.2.0, 1.3.0 Aug 21, 2017
@lafriks
lafriks merged commit fd8e8a4 into go-gitea:master Aug 21, 2017
@sapk sapk mentioned this pull request Sep 5, 2017
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@appleboy appleboy appleboy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sapk @appleboy @lunny @lafriks @tboerger