Fix PR nil-dereference bug - #2195
Merged
Merged
Conversation
lafriks
added
the
lgtm/need 2
Contributor
|
Trusted LGTM |
lafriks
added
lgtm/need 1
lafriks
reviewed
Jul 23, 2017
| if IsErrPullRequestNotExist(err) { | ||
| return err | ||
| } | ||
| return fmt.Errorf("getPullRequestByIssueID: %v", err) |
Member
Author
There was a problem hiding this comment.
Causality of moving code around, I'll change it back to what it previously was (fmt.Errorf("getPullRequestByIssueID [%d]: %v", issue.ID, err))
lafriks
reviewed
Jul 23, 2017
| if IsErrPullRequestNotExist(err) { | ||
| return err | ||
| } | ||
| return fmt.Errorf("getPullRequestByIssueID [%d]: %v", issue.ID, err) |
Member
There was a problem hiding this comment.
But still I think it should be loadPullRequest in error message
Member
Author
There was a problem hiding this comment.
I can change it if you really want, but this is more consistent with the other loadXYZ(..) methods.
Member
There was a problem hiding this comment.
Sorry it is correct you are right
Member
|
LGTM |
lafriks
added
lgtm/done
Member
|
please force empty push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2190. Also adds unit tests for previously-broken methods.