Fix compiling without sqlite and gcc - #2177
Merged
Merged
Conversation
lafriks
added
the
topic/build
Member
|
No. the build tag is not in the correct place |
tboerger
added
the
lgtm/need 2
lafriks
force-pushed
the
fix/build_without_sqlite
branch
from
July 18, 2017 05:21
d0a5416 to
ccde6b8
Compare
Member
Author
|
@lunny sorry that build tag was leftover from first try to fix compilation with no gcc, it was not needed, fixed |
lafriks
force-pushed
the
fix/build_without_sqlite
branch
from
July 18, 2017 13:46
ccde6b8 to
82f5283
Compare
Member
|
maybe rename models/unit_tests.go to models/unit_test.go is better? |
Member
|
@lunny No, it is important that |
Member
|
LGTM |
tboerger
added
lgtm/need 1
Member
|
LGTM |
lafriks
added
lgtm/done
Member
|
make CI work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2172