Skip to content

Cache session cookies in tests - #2128

Merged
lunny merged 1 commit into
go-gitea:masterfrom
ethantkoenig:test/cache_session
Jul 9, 2017
Merged

Cache session cookies in tests#2128
lunny merged 1 commit into
go-gitea:masterfrom
ethantkoenig:test/cache_session

Conversation

@ethantkoenig

@ethantkoenig ethantkoenig commented Jul 8, 2017

Copy link
Copy Markdown
Member

Cache session cookies in integration tests to avoid repeatedly logging in. Makes tests a little faster (make test-mysql goes from 34 to 30 seconds on my laptop)

@Bwko

Bwko commented Jul 8, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 9, 2017
@lunny

lunny commented Jul 9, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2017
@lunny
lunny merged commit 89cd4dd into go-gitea:master Jul 9, 2017
@ethantkoenig
ethantkoenig deleted the test/cache_session branch July 9, 2017 12:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants