Fix wording - #2024
Merged
Merged
Conversation
Member
|
Maybe we should change the key and there are any other places to use this word? |
tboerger
added
the
lgtm/need 2
Contributor
Author
|
@lunny No, there are not any other places using this word. If you want, I can change the key. |
Member
|
I think the key should be changed |
Contributor
Author
|
Done. I have added a new key The failed build is not because of this. Proof: https://staging.geek1011.net/user/login?redirect_to=%2fuser%2fsettings%2fkeys |
Member
|
LGTM |
tboerger
added
lgtm/need 1
Member
|
LGTM |
tboerger
added
lgtm/done
appleboy
approved these changes
Jun 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a key which never expires, it used to say
Valid until never. It should beforever.