Skip to content

Add integration test for issue creating - #2002

Merged
lunny merged 1 commit into
go-gitea:masterfrom
typeless:add-integration-test-for-issues
Jun 18, 2017
Merged

Add integration test for issue creating#2002
lunny merged 1 commit into
go-gitea:masterfrom
typeless:add-integration-test-for-issues

Conversation

@typeless

Copy link
Copy Markdown
Contributor

No description provided.

@ethantkoenig

Copy link
Copy Markdown
Member

Would it be possible to check that the issue was actually created? (by models.AssertExistsAndLoadBean(..), or if that's not possible by making a GET request to view it)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2017
@ethantkoenig

Copy link
Copy Markdown
Member

@typeless Also, thank you for adding integration tests! I appreciate your willingness to do unglamorous-but-important tasks like writing tests.

@typeless
typeless force-pushed the add-integration-test-for-issues branch from 2c3396c to d8bbd9e Compare June 18, 2017 03:28
@typeless

Copy link
Copy Markdown
Contributor Author

@ethantkoenig I have added a GET request to check the existence of the issue page. And I don't quite understand how AssertExistsAndLoadBean is used here.

@lunny lunny added this to the 1.2.0 milestone Jun 18, 2017
@ethantkoenig

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2017
@lunny

lunny commented Jun 18, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2017
@lunny
lunny merged commit 4d2ea7d into go-gitea:master Jun 18, 2017
@typeless
typeless deleted the add-integration-test-for-issues branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants