Skip to content

fix collborators lack of units on orgnization repositories - #1968

Merged
bkcsoft merged 2 commits into
go-gitea:masterfrom
lunny:lunny/fix_collaborator_units
Jun 15, 2017
Merged

fix collborators lack of units on orgnization repositories#1968
bkcsoft merged 2 commits into
go-gitea:masterfrom
lunny:lunny/fix_collaborator_units

Conversation

@lunny

@lunny lunny commented Jun 14, 2017

Copy link
Copy Markdown
Member

will fix #1947, @typeless please confirm this PR fixed #1947

@lunny lunny added the type/bug label Jun 14, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 14, 2017
Comment thread integrations/sqlite.ini

[log.console]
LEVEL = Warn
LEVEL = Debug

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change sqlite.ini but not mysql.ini or pgsql.ini?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@ethantkoenig

Copy link
Copy Markdown
Member

One minor thing, otherwise LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 14, 2017
@typeless

Copy link
Copy Markdown
Contributor

It works.

@bkcsoft

bkcsoft commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2017
@bkcsoft
bkcsoft merged commit 31b5e91 into go-gitea:master Jun 15, 2017
@lunny
lunny deleted the lunny/fix_collaborator_units branch June 15, 2017 02:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to git-push to existing repos (probably related to the unit feature)

5 participants