Skip to content

Require token before checking membership/ownership - #1905

Merged
andreynering merged 1 commit into
go-gitea:masterfrom
ethantkoenig:fix/org_api_auth
Jun 7, 2017
Merged

Require token before checking membership/ownership#1905
andreynering merged 1 commit into
go-gitea:masterfrom
ethantkoenig:fix/org_api_auth

Conversation

@ethantkoenig

@ethantkoenig ethantkoenig commented Jun 7, 2017

Copy link
Copy Markdown
Member

Call the reqToken() handler before calling the reqOrgMembership() or reqOrgOwnership() handlers. Failing to do so results in a 500 for unauthenticated users (see error from #1899)

@andreynering

Copy link
Copy Markdown
Contributor

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 7, 2017
@andreynering andreynering added this to the 1.2.0 milestone Jun 7, 2017
@lafriks

lafriks commented Jun 7, 2017

Copy link
Copy Markdown
Member

LGTM

@lafriks

lafriks commented Jun 7, 2017

Copy link
Copy Markdown
Member

Make LG-TM work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 7, 2017
@andreynering
andreynering merged commit 65cf6cc into go-gitea:master Jun 7, 2017
@ethantkoenig
ethantkoenig deleted the fix/org_api_auth branch June 8, 2017 14:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants