Skip to content

Prevent accidential selection of line numbers in code view - #1860

Merged
appleboy merged 1 commit into
go-gitea:masterfrom
silverwind:linnum-no-select
Jun 5, 2017
Merged

Prevent accidential selection of line numbers in code view#1860
appleboy merged 1 commit into
go-gitea:masterfrom
silverwind:linnum-no-select

Conversation

@silverwind

@silverwind silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member

Before:

nums-before

After:

nums-after

@appleboy

appleboy commented Jun 3, 2017

Copy link
Copy Markdown
Member

@silverwind Please also update the css file.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2017
@appleboy appleboy added the type/enhancement An improvement of existing functionality label Jun 3, 2017
@appleboy appleboy added this to the 1.2.0 milestone Jun 3, 2017
@silverwind

silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member Author

Done, but an unrelated change got built in the css.

@silverwind

silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member Author

Might be better to untrack the css from git :)

@appleboy

appleboy commented Jun 3, 2017

Copy link
Copy Markdown
Member

@silverwind I can take it but thanks for your update.

@appleboy

appleboy commented Jun 3, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 3, 2017
@silverwind

silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member Author

@appleboy I'll look into overhauling the assets build.

@appleboy appleboy mentioned this pull request Jun 3, 2017
Merged
@appleboy

appleboy commented Jun 3, 2017

Copy link
Copy Markdown
Member

@silverwind move discussions to #1861

@lafriks

lafriks commented Jun 3, 2017

Copy link
Copy Markdown
Member

LGTM if for now you could manualy add back removed css part so that PR code would be cleaner

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2017
@silverwind

silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member Author

LGTM if for now you could manualy add back removed css part so that PR code would be cleaner

Just land the two commits seperately.

@appleboy

appleboy commented Jun 3, 2017

Copy link
Copy Markdown
Member

@silverkorn Please add back removed css part since you don't remove any source code from less file.

@silverwind

silverwind commented Jun 3, 2017

Copy link
Copy Markdown
Member Author

Found the issue, my local branch was out of date and did not include #1288. After rebasing, make assets did the right thing.

pgaskin
pgaskin approved these changes Jun 4, 2017
View reviewed changes

@pgaskin pgaskin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than my comments.

Comment thread public/less/_repository.less Outdated

@pgaskin pgaskin Jun 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such thing. It should be -ms-user-select, not -ws-user-select.

Comment thread public/css/index.css Outdated

@pgaskin pgaskin Jun 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such thing. It should be -ms-user-select, not -ws-user-select.

@silverwind

silverwind commented Jun 5, 2017

Copy link
Copy Markdown
Member Author

@geek1011 fixed that typo. I wish we would use Autoprefixer to prevent issues like that :)

@appleboy
appleboy merged commit ae922af into go-gitea:master Jun 5, 2017
@silverkorn

silverkorn commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

@appleboy , Thanks for the typo in the username, you sent me a notice and now I know about this project! 😆
Adding a star right now!

@appleboy

appleboy commented Jun 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@silverkorn Sorry for tag wrong name. 👍 I hope I'm not bothering you.

@silverwind silverwind mentioned this pull request Jul 31, 2017
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
@wxiaoguang
wxiaoguang deleted the linnum-no-select branch December 18, 2025 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@appleboy appleboy appleboy approved these changes
@pgaskin pgaskin pgaskin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@silverwind @appleboy @lafriks @silverkorn @pgaskin @tboerger