Use a better default MAX_GIT_DIFF_LINE_CHARACTERS - #1845
Merged
Conversation
Tests indicate that line length alone does not make browsers slow, so increase the default threshold after which diffs get surpressed for line length from 500 to a more reasonable 5000 characters. Fixes: go-gitea#1826
Member
|
LGTM |
tboerger
added
the
lgtm/need 2
appleboy
approved these changes
Jun 1, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
lunny
pushed a commit
that referenced
this pull request
Oct 25, 2017
MAX_GIT_DIFF_LINE_CHARACTERS was updated in #1845 but the corresponding default value of MaxGitDiffLineCharacters was not changed. This can lead to inconsistencies.
lafriks
pushed a commit
that referenced
this pull request
Oct 25, 2017
vdbt
pushed a commit
to vdbt/gitea
that referenced
this pull request
Oct 27, 2017
MAX_GIT_DIFF_LINE_CHARACTERS was updated in go-gitea#1845 but the corresponding default value of MaxGitDiffLineCharacters was not changed. This can lead to inconsistencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests indicate that line length alone does not make browsers slow, so increase the default threshold after which diffs get surpressed for line length from 500 to a more reasonable 5000 characters.
Fixes: #1826