Fix activity feed

[ethantkoenig]

Preserve actions after user/repo name change. Fixes #1730.

Essentially removes the act_user_name, repo_user_name, and repo_name columns from the action table (which can become stale when a user/repo changes name). There's really no point in having the act_user_name column, since you have the load the user for the avatar link anyways.

NOTE: I'm having some trouble getting the migration to work; if anyone knows how to drop columns with xorm, please help me out.

[lunny]

But this will not remove the column currently.

[ethantkoenig]

I know, I made a note of it in the PR description. How does one remove columns with xorm?

[sapk]

Not the best at xorm but you could still execute sql and pass a ALTER TABLE command

[lunny]

This will also drop #1744

[sapk]

It will be more easy/clean to remove :

 	ActUserID    int64  `xorm:"INDEX"` // Action user id.
	ActUserName  string // Action user name.
 	ActAvatar    string `xorm:"-"`
 	RepoID       int64  `xorm:"INDEX"`
	RepoUserName string
	RepoName     string

and simply use ActUser *User et Repo *Repository and let xorm make the linking.

[ethantkoenig]

@sapk Updated the migration, and took your suggestion about the fields for the Action struct

[ethantkoenig]

Build timed out 😢

[sapk]

You could easely restart the build by doing a git commit --amend and pushing (with -f) the new commit ;-).
We should add an issue for this problem that were seing more and more with the addition of test.

[ethantkoenig]

Rebased onto master to retrigger build

[lunny]

How about add some new tests?

[lunny]

LGTM

[lafriks]

LGTM