Don't recreate database in integration tests - #1697
Merged
Merged
Conversation
Contributor
|
LGTM |
tboerger
added
the
lgtm/need 1
Member
|
LGTM |
tboerger
added
lgtm/done
appleboy
approved these changes
May 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was previously an issue with the test database not being cleared between runs of the integration suite; this problem was fixed in #1693 by deleting and re-creating the test database each time tests are run
This fixes the problem, but is really slow. I realized that the reason the test database wasn't being cleared was due to a missing test fixture file. This PR adds the missing fixture, and removing the now-unnecessary deletion and recreation of test databases.