Improve dashboard repo search - #1652
Conversation
|
well, LGTM to me, as for removing the other panel I'm fine with that 🙂 |
|
@lunny Not sure what could be wrong, it works for me. Did you run |
|
I didn't run |
|
@lunny Sorry, If you are compiling with bindata you should run Can also be a an cache issue. Otherwise, I don't know what's the problem. 🤔 |
|
Updated. I fixed an issue with the repos/orgs/mirrors tabs switching. @bkcsoft I decided to keep the other panel for now, because the api is not yet showing repos you're just a colaborator and not owner. That panel shows exactly that. We could change that in another PR. @lunny Which browser are you using? Any errors on JS console? |
|
I used chrome on Mac OS. but seems it fixed when I update to the latest commit of this PR. |
|
so LGTM |
|
let L-G-T-M work |
|
don't merge this until v1.2 released. |
|
@lunny Why wait until after 1.2? (Added |
|
I don't know. @andreynering maybe we can put it back to v1.2 since this is not a big feature. |
|
I'm ok with that
Em 08/05/2017 5:26 AM, "Lunny Xiao" <notifications@github.com> escreveu:
… I don't know. @andreynering <https://github.com/andreynering> maybe we
can put it back to v1.2 since this is not a big feature.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1652 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGr966V2uU8iOYGh6xKsuuGsIt7rDtwSks5r3tGigaJpZM4NNE-9>
.
|

Improvement of #872
I think the last thing to discuss is wether we should remove the other repo panels, since this one now show all repos visible to the logged in user.