Skip to content

Improve dashboard repo search - #1652

Merged
lunny merged 4 commits into
go-gitea:masterfrom
andreynering:dashboard-search
May 9, 2017
Merged

Improve dashboard repo search#1652
lunny merged 4 commits into
go-gitea:masterfrom
andreynering:dashboard-search

Conversation

@andreynering

Copy link
Copy Markdown
Contributor

Improvement of #872

I think the last thing to discuss is wether we should remove the other repo panels, since this one now show all repos visible to the logged in user.

@andreynering andreynering added the topic/ui Change the appearance of the Gitea UI label May 1, 2017
@andreynering andreynering added this to the 1.3.0 milestone May 1, 2017
@bkcsoft

bkcsoft commented May 3, 2017

Copy link
Copy Markdown
Contributor

well, LGTM to me, as for removing the other panel I'm fine with that 🙂

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 3, 2017
@lunny

lunny commented May 4, 2017

Copy link
Copy Markdown
Member

This is my screenshot. It seems it's not ready?
untitled

@andreynering

Copy link
Copy Markdown
Contributor Author

@lunny Not sure what could be wrong, it works for me.

Did you run make assets? Any error on the JS console?

@lunny

lunny commented May 4, 2017

Copy link
Copy Markdown
Member

I didn't run make assets, make: Nothing to be done for assets'.`.

@andreynering

Copy link
Copy Markdown
Contributor Author

@lunny Sorry, make assets by now is just for CSS, not JS.

If you are compiling with bindata you should run make generate.

Can also be a an cache issue. Otherwise, I don't know what's the problem. 🤔

@andreynering

Copy link
Copy Markdown
Contributor Author

Updated. I fixed an issue with the repos/orgs/mirrors tabs switching.

@bkcsoft I decided to keep the other panel for now, because the api is not yet showing repos you're just a colaborator and not owner. That panel shows exactly that. We could change that in another PR.

@lunny Which browser are you using? Any errors on JS console?

@lunny

lunny commented May 7, 2017

Copy link
Copy Markdown
Member

I used chrome on Mac OS. but seems it fixed when I update to the latest commit of this PR.

@lunny

lunny commented May 7, 2017

Copy link
Copy Markdown
Member

so LGTM

@lunny

lunny commented May 7, 2017

Copy link
Copy Markdown
Member

let L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2017
@lunny

lunny commented May 7, 2017

Copy link
Copy Markdown
Member

don't merge this until v1.2 released.

@bkcsoft bkcsoft added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label May 8, 2017
@bkcsoft

bkcsoft commented May 8, 2017

Copy link
Copy Markdown
Contributor

@lunny Why wait until after 1.2? (Added status/blocked in the meanwhile)

@lunny

lunny commented May 8, 2017

Copy link
Copy Markdown
Member

I don't know. @andreynering maybe we can put it back to v1.2 since this is not a big feature.

@andreynering

andreynering commented May 8, 2017 via email

Copy link
Copy Markdown
Contributor Author

@lunny lunny modified the milestones: 1.2.0, 1.3.0 May 9, 2017
@lunny lunny removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label May 9, 2017
@lunny
lunny merged commit ab79069 into go-gitea:master May 9, 2017
@andreynering
andreynering deleted the dashboard-search branch May 9, 2017 01:05
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants