Expose the OpenID registration setting at install time - #1365
Closed
strk wants to merge 1 commit into
Closed
Conversation
7 tasks
Member
Author
|
Ok don't merge this, I got a better idea. |
tboerger
added
the
lgtm/need 2
Member
Author
|
So @Schnouki I'm thinking that at installation time you'd still ony have a DISABLE_REGISTRATION setting, then at runtime you should be able to override it for just openid anyway, but by not specifying an explicit setting for it it owuld default to whatever the global specified. |
Member
Author
|
Uhm, my idea is problematic because the DisableRegistration config variable is read in a different function than the place where EnableOpenIDRegistration is read. |
Member
|
Why we need another option to disable OpenID registered? |
Member
Author
|
@lunny because some admins want to keep registration open only for those who can provide a valid OpenID identity |
Member
Author
|
Ok see #1369 for an implementation of that idea of mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1363
To be honest, I don't really like this even myself :P