Skip to content

Fix broken table layout - #1344

Merged
lunny merged 1 commit into
go-gitea:masterfrom
cez81:fix_readme_layout
Mar 21, 2017
Merged

Fix broken table layout#1344
lunny merged 1 commit into
go-gitea:masterfrom
cez81:fix_readme_layout

Conversation

@cez81

@cez81 cez81 commented Mar 20, 2017

Copy link
Copy Markdown
Contributor

The table layout in the README is broken after Github's change of markdown renderer. This PR will fix that and display the screenshots in a 3x3 table.
Github markdown doesn't support tables without headers so there's an empty row at the top.
Looks ok in Gitea too, https://try.gitea.io/cez81/gitea/src/fix_readme_layout/README.md.

References:
https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown
github/markup#1010 (comment)

@lunny lunny added this to the 1.2.0 milestone Mar 21, 2017
@lunny lunny added the type/bug label Mar 21, 2017
@lunny

lunny commented Mar 21, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 21, 2017
@ethantkoenig

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2017
@lunny
lunny merged commit 9a9f8fa into go-gitea:master Mar 21, 2017
@cez81
cez81 deleted the fix_readme_layout branch March 21, 2017 10:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants