Add change-password admin command by strk · Pull Request #1304 · go-gitea/gitea

strk · 2017-03-17T14:54:43Z

Not working yet, need help

ptman · 2017-03-17T14:56:56Z

It's not being printed.

I meant, that the encoded password isn't being printed. Should the usage not just be "change password of a user" ?

Ah, of course, will fix and squash

strk · 2017-03-17T15:29:05Z

It is now: $ ./gitea admin --help | grep change change-password Print encoded version of a given password

appleboy · 2017-03-17T16:05:35Z

LGTM

strk · 2017-03-17T16:53:33Z

@ptman better now ?

Do you think an error should be printed for users whose LoginSource != LOCAL/PLAIN ?
(but note that the OAuth2 users still have a broken LoginSource: #1143)

ptman · 2017-03-17T17:00:41Z

Yes, much better. And you're right about giving an error for users where it wouldn't be effective or some other method may still allow them to log in (if trying to disable with password change)

strk · 2017-03-17T17:04:25Z

@ptman I'd postpone that part to after #1143 is done, or I'd have to add more conditionals there to deal with OAuth2 in a special way, which I'd hate...

lunny · 2017-03-18T03:14:17Z

Why not just password?

No reason, this was suggested by @bkcsoft on IRC if I recall correctly, and I thought it was a clean and self-describing name

change-password is too long for a command, I think password is better!

vote password

@lunny @appleboy we already have create-user so I don't really see the issue with change-password. Then it becomes self-explaining :)

pgaskin · 2017-03-18T22:13:54Z

LGTM

strk · 2017-03-19T06:49:49Z

You also have to type --username and --password so it is balanced to me --strk; Sent from hand-held device, sorry for brevity

appleboy · 2017-03-19T07:07:21Z

support -u or --username. Maybe username,u

appleboy · 2017-03-19T07:07:39Z

support -p or --password. Maybe password,p

lunny · 2017-03-19T08:29:24Z

agree with @appleboy

strk · 2017-03-19T08:44:43Z

This PR has 2 LGTM, please merge

appleboy · 2017-03-19T09:03:58Z

@strk Do you see my suggestions about adding more flags?

strk · 2017-03-19T09:20:36Z

@appleboy added -u and -p options, and rebased

strk · 2017-03-19T09:21:48Z

so I'm also happy with just "passwd" as the admin name (to reflect the unix command) but as the only existing command is create-user I think it's consistent to have change-password as is. Can it be merged now ? (the rules say 2 LGTM are enough to merge...)

tboerger

Generally I would prefer a user sub-command instead of admin.

tboerger · 2017-03-19T09:27:49Z

+			cli.StringFlag{
+				Name:  "username,u",
+				Value: "",
+				Usage: "Username",


Pretty useless usage information.

tboerger · 2017-03-19T09:27:57Z

+			cli.StringFlag{
+				Name:  "password,p",
+				Value: "",
+				Usage: "Password",


Pretty useless usage information.

strk · 2017-03-19T15:01:10Z

If every single maintainer complains about something this will become much slower than Gogs. It's already happening that Gogs is ahead. This PR got 2 positive reviews, so about the rules it should just be merged.

If you think maintainers should also have veto powers so please add a section about that in the CONTRIBUTING.md file.

bkcsoft · 2017-03-20T07:57:00Z

@tboerger don't really see the point of having gitea user [...] since they are inheritly admin commands 😉

bkcsoft · 2017-03-20T08:10:15Z

LGTM working?

appleboy · 2017-03-20T08:16:59Z

LGTM is working but waiting build status.

appleboy · 2017-03-20T08:17:42Z

@bkcsoft Thanks for improving usage information

ptman reviewed Mar 17, 2017

View reviewed changes

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2017

appleboy approved these changes Mar 17, 2017

View reviewed changes

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2017

strk changed the title ~~Add change-password admin command (panicing)~~ Add change-password admin command Mar 17, 2017

strk force-pushed the change-password branch from be05258 to 3c1fcee Compare March 17, 2017 16:52

lunny added this to the 1.2.0 milestone Mar 18, 2017

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 18, 2017

lunny reviewed Mar 18, 2017

View reviewed changes

strk force-pushed the change-password branch from 3c1fcee to 20ede98 Compare March 18, 2017 13:12

tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2017

appleboy reviewed Mar 19, 2017

View reviewed changes

Comment thread cmd/admin.go Outdated

appleboy Mar 19, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support -u or --username. Maybe username,u

appleboy reviewed Mar 19, 2017

View reviewed changes

Comment thread cmd/admin.go Outdated

appleboy Mar 19, 2017 •

edited

Loading

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support -p or --password. Maybe password,p

strk added 2 commits March 19, 2017 10:20

Add change-password admin command

e6cbf2f

Allow using -u for username and -p for password

6d201e8

strk force-pushed the change-password branch from 20ede98 to 6d201e8 Compare March 19, 2017 09:20

tboerger reviewed Mar 19, 2017

View reviewed changes

bkcsoft added 2 commits March 20, 2017 09:09

Better Usage-strings

3bdc46d

Update admin.go

dc5e098

bkcsoft merged commit e158689 into go-gitea:master Mar 20, 2017

strk deleted the change-password branch March 20, 2017 08:35

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Uh oh!

Uh oh!

Conversation

strk commented Mar 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strk commented Mar 17, 2017 via email

Uh oh!

appleboy commented Mar 17, 2017

Uh oh!

strk commented Mar 17, 2017

Uh oh!

ptman commented Mar 17, 2017

Uh oh!

strk commented Mar 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgaskin commented Mar 18, 2017

Uh oh!

strk commented Mar 19, 2017 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

appleboy Mar 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lunny commented Mar 19, 2017

Uh oh!

strk commented Mar 19, 2017

Uh oh!

appleboy commented Mar 19, 2017

Uh oh!

strk commented Mar 19, 2017

Uh oh!

strk commented Mar 19, 2017

Uh oh!

tboerger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strk commented Mar 19, 2017

Uh oh!

bkcsoft commented Mar 20, 2017

Uh oh!

bkcsoft commented Mar 20, 2017

Uh oh!

appleboy commented Mar 20, 2017

Uh oh!

appleboy commented Mar 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

appleboy Mar 19, 2017 •

edited

Loading