Skip to content

Add LibreJS support - #1201

Merged
lunny merged 1 commit into
go-gitea:masterfrom
strk:librejs
Mar 12, 2017
Merged

Add LibreJS support#1201
lunny merged 1 commit into
go-gitea:masterfrom
strk:librejs

Conversation

@strk

@strk strk commented Mar 10, 2017

Copy link
Copy Markdown
Member

@lunny

lunny commented Mar 11, 2017

Copy link
Copy Markdown
Member

Why we need to add this?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2017
@strk

strk commented Mar 11, 2017

Copy link
Copy Markdown
Member Author

We want (not need) this to properly advertise the license of the Javascript code we ask users to execute.
Some users don't want to run proprietary software so refuse to run Javascript code if it's not free software. There are browser plugins for that. You can read more about the rationale (the "Javascript trap") in the link placed in the original submission.

@strk

strk commented Mar 11, 2017

Copy link
Copy Markdown
Member Author

Reporting the link here: https://www.gnu.org/philosophy/javascript-trap.html

@pgaskin

pgaskin commented Mar 12, 2017

Copy link
Copy Markdown
Contributor

This should be merged because it is not a big change, and it will make managing the licenses of different libraries easier.

@lunny

lunny commented Mar 12, 2017

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 12, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 12, 2017
@appleboy

Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2017
@lunny
lunny merged commit f0efb61 into go-gitea:master Mar 12, 2017
@strk
strk deleted the librejs branch March 15, 2017 09:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add LibreJS support

5 participants