API /commits returns incorrect X-Total-Count when using since/until filters (v1.25)

[LemonHD1337]

Description

When requesting commits with the since, until, and sha query parameters, the API correctly filters commits in the response body, but the X-Total-Count header still shows the total number of commits in the repository.

Gitea Version

1.25.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Ubuntu

How are you running Gitea?

Self-hosted instance
Installed using Docker on a Linux host
Gitea was not built manually — using a standard Docker image from Gitea.

Database

PostgreSQL

[puni9869]

Let me reproduce it.

[puni9869]

Did a RCA on this issue last week:-
Need some suggestion:

In api
// swagger:operation GET /repos/{owner}/{repo}/commits repository repoGetAllCommits

What if len(path) ==0 and I don't pass sha and pass (until and since value) in url like

http://localhost:3000/api/v1/repos/puni9869/Test2/commits?since=2026-06-11T00:00:00Z&until=2026-06-06T23:59:59Z

Where since=2026-06-11T00:00:00Z&until=2026-06-06T23:59:59Z

So by default it will pick the
baseCommit, err = ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch)
DefaultBranc.ID

and further it will filter based on dates since and until. In my case it will be [] array. Since date is for tomorrow.

So in header we are passing X-Total and X-Total-Count that shows total number of commits as per code flow :

commitsCountTotal, err = gitrepo.CommitsCount(ctx, ctx.Repo.Repository, gitrepo.CommitsCountOptions{

Inside function its not passing until and since. function CommitsCount check image.

Hence get the full detail of commit.
So In response I am getting empty array which is correct. But in the header we are exposing the total count of commits in X-Total and X-Total-Count.

Want to know your feedback on this.

My thoughts :-

It should depends on commits between range and pagination logic.
X-Total-Count only make sense when we have pagination.

If len(commits) > 0 :
Then only provide original values of X-Total and X-Total-Count .

[puni9869]

@augustocbx before you pick any issue, if it is already assigned, please notify through a comment that you will be working on this or any issue so that the assignee can share their part of progress which is already done.