Rewrite test-git-versions.sh in PHP and update the tested git versions - #251
Merged
Conversation
Port the git-version build/test tool to PHP with Symfony Console and Process, matching the style of tests/fixtures/generate-bundle.php, and split it into a "build" and a "test" command. Update the curated version list to versions picked for how long and widely each shipped as the default git on a major distro: v1.7.1 (RHEL/CentOS 6), v1.8.3.1 (RHEL/CentOS 7), v2.17.1 (Ubuntu 18.04), v2.25.1 (20.04), v2.34.1 (22.04), v2.43.0 (24.04).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-git-versions.shtotest-git-versions.php, using Symfony Console and Process in the same style astests/fixtures/generate-bundle.php, split into abuildand atestcommand.v1.7.1(RHEL/CentOS 6),v1.8.3.1(RHEL/CentOS 7),v2.17.1(Ubuntu 18.04),v2.25.1(20.04),v2.34.1(22.04),v2.43.0(24.04).-std=gnu17(GCC 15's C23unreachable()macro collides with an identifier in git's own source), and skipimap-send/Python/Tcl-Tk extras (NO_OPENSSL,NO_PYTHON,NO_TCLTK) which aren't needed and don't build cleanly on old sources.HOME/XDG_CONFIG_HOMEso the developer's own~/.gitconfig(e.g.merge.conflictstyle = zdiff3, unknown to git < 2.35) can't leak into the subprocess and cause spurious failures.test-git-versions.shreference in.github/CONTRIBUTING.mdand gitignored/git-builds/.Ran
buildthentestend-to-end against all six versions locally.v2.17.1throughv2.43.0pass cleanly.v1.7.1andv1.8.3.1currently fail —v1.7.1doesn't supportgit config --local(added in 1.7.10) which gitlib's tests use, and both hit aDiffParsererror on their diff header format. These look like genuine compatibility gaps surfaced by the tool rather than script bugs; left as-is for a separate discussion/fix.Test plan
php test-git-versions.php buildthenphp test-git-versions.php testrun against all six curated versionscastor qa:cs:cs --dry-runclean on the new file