Fix relative paths not resolving against the repository in Repository::run() - #249
Merged
Conversation
…::run() The git process spawned by Repository::run() never had its working directory set, so Symfony Process defaulted it to the calling PHP script's cwd. Commands such as "apply" resolve the paths referenced inside their arguments (e.g. the files listed in a patch) against the process cwd rather than --work-tree, so running them from outside the repository directory failed with errors like "No such file or directory" even though --git-dir/--work-tree were correctly set. Fixes #67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository::getProcess()never set the spawned git process's working directory, so it defaulted to the calling PHP script's cwd instead of the repository.applyresolve paths referenced in their arguments (e.g. the files listed in a patch) against the process cwd rather than--work-tree, so running them from outside the repository directory failed with errors likeerror: hello.txt: No such file or directory, as reported in Problems with Applying and reverting patches #67.$this->getPath()) when building the process.Fixes #67
Test plan
error: README.md: No such file or directory) and passes with it.vendor/bin/phpunit).