Add Repository::runProcess() to expose stderr on successful commands - #247
Merged
Conversation
Repository::run() only ever returns stdout, even on success. Some git commands (push, in particular) write their meaningful output to stderr even when they succeed, so callers had no way to read it (#205). runProcess() returns the full, already-run Process instead, giving access to getErrorOutput(). run() now delegates to it and keeps its exact original behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository::run()only ever returns stdout, even when the process succeeds. Some git commands (push, in particular) write their meaningful output to stderr even on success, so callers had no way to read it.Fixes #205.
Changes
run()into a new public methodrunProcess(), which returns the full, already-runSymfony\Component\Process\Processinstead of just stdout.run()now delegates torunProcess()and keeps its exact original behavior (stdout-only,nullon failure, throws in debug mode) — fully backward compatible.push) can now do:Test plan
runProcess()exposing stderr on success and returning a failed (non-throwing) process whendebugis offvendor/bin/phpunit)