Case insensitive fallback check for GitHub repositories#978
Merged
aeisenberg merged 2 commits intogithub:mainfrom Oct 20, 2021
Merged
Case insensitive fallback check for GitHub repositories#978aeisenberg merged 2 commits intogithub:mainfrom
aeisenberg merged 2 commits intogithub:mainfrom
Conversation
aeisenberg
reviewed
Oct 20, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. Can you please squash the commits here so that history is more succinct? Let me know if you need some help doing this.
…ng an LGTM project.
mgsium
force-pushed
the
case-insensitive-slugs
branch
from
46c12a4 to
1014c4b
Compare
aeisenberg
reviewed
Oct 20, 2021
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Nice...tried it out locally and it is still working.
One last thing to do and 🚢 .
Comment on lines
+17
to
+22
| - Fixed a bug where copying the version information fails when a CodeQL CLI cannot be found. [#958](https://github.com/github/vscode-codeql/pull/958) | ||
| - Fix a bug where copying the version information fails when a CodeQL CLI cannot be found. [#958](https://github.com/github/vscode-codeql/pull/958) | ||
| - Avoid a race condition when deleting databases that can cause occasional errors. [#959](https://github.com/github/vscode-codeql/pull/959) | ||
| - Update CodeQL logos. [#965](https://github.com/github/vscode-codeql/pull/965) | ||
| - Fixed a bug where copying the version information fails when a CodeQL CLI cannot be found. [#958](https://github.com/github/vscode-codeql/pull/958) | ||
| - Make project slug for GitHub repositories case-insensitive when adding a CodeQL database from LGTM. [#961](https://github.com/github/vscode-codeql/pull/961) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a case-insensitive fallback check for the /g/ provider where a repository is not found on LGTM using a case-sensitive search. Partially fixes #892
Checklist