Avoid showing a link when the underlying path is empty#546
Merged
aeisenberg merged 2 commits intogithub:mainfrom Sep 2, 2020
Merged
Avoid showing a link when the underlying path is empty#546aeisenberg merged 2 commits intogithub:mainfrom
aeisenberg merged 2 commits intogithub:mainfrom
Conversation
A common situation when a file is not relevant for a particular result is to return an empty file path location. Currently, we are displaying this situation as a hyperlink in the results, but when clicking on the link, there is an error. To mirror the behaviour of Eclipse, we should avoid showing a link here. This commit changes that behaviour.
jcreedcmu
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common situation when a file is not relevant for a particular result
is to return an empty file path location.
Currently, we are displaying this situation as a hyperlink in the
results, but when clicking on the link, there is an error.
To mirror the behaviour of Eclipse, we should avoid showing a link here.
This commit changes that behaviour.
Fixes #545
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.Not notifying
@github/docs-content-dspbecause this is a small change that external users will unlikely to come across.