Move codeQL.exportSelectedVariantAnalysisResults to query history manager#2192
Merged
robertbrignull merged 2 commits intomainfrom Mar 22, 2023
Merged
Conversation
koesie10
approved these changes
Mar 21, 2023
| "codeQLQueryHistory.openOnGithub": SelectionCommandFunction<QueryHistoryInfo>; | ||
| "codeQLQueryHistory.copyRepoList": SelectionCommandFunction<QueryHistoryInfo>; | ||
|
|
||
| // Commands in the command pallete |
Member
There was a problem hiding this comment.
Suggested change
| // Commands in the command pallete | |
| // Commands in the command palette |
robertbrignull
deleted the
robertbrignull/export_selected_results_command
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on from #2186 and is also tangentially related to converting the variant analysis commands (#2191).
I think this command probably fits best on the query history manager, because it is acting on the variant analysis currently selected in the query history panel. I've checked and having a view open does not affect it. It's purely operating on the query history selection state.
Checklist
ready-for-doc-reviewlabel there.