Merged
Conversation
This tests occasionally times out during setup. This change attempts to avoid this problem by increasing the max length of the test.
Contributor
|
Any idea why setting up would take more than 20 seconds? Sounds like a lot! |
Contributor
Author
|
20 seconds was arbitrary. I chose that since we have other tests with a 20s timeout. We can probably go with a shorter timeout, but there are a number of things that take extra time:
|
charisk
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests occasionally times out during setup. This change attempts to avoid this problem by increasing the max length of the test.
@elenatanasoiu this fix might be an alternative to #1695.
Checklist
ready-for-doc-reviewlabel there.