Skip to content

Implement setVariantAnalysis message #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 7 commits into from
Oct 5, 2022
Merged

Implement setVariantAnalysis message #1562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
401da63
Keep track of opened variant analysis views
koesie10 Oct 3, 2022
28b00b2
Update variant analysis from API response
koesie10 Oct 3, 2022
1557901
Emit event when variant analysis is updated
koesie10 Oct 3, 2022
2baa53a
Post message to view when variant analysis is updated
koesie10 Oct 3, 2022
84621b7
Fix variant analysis monitor failing
koesie10 Oct 3, 2022
525d7f5
Receive setVariantAnalysis message in React component
koesie10 Oct 3, 2022
6941584
Add variant analysis view to disposables of manager
koesie10 Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
logger: Logger,
) {
super();
this.variantAnalysisMonitor = new VariantAnalysisMonitor(ctx, logger);
this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx, logger));
Comment thread
elenatanasoiu marked this conversation as resolved.
}

public async showView(variantAnalysisId: number): Promise<void> {
Expand Down
11 changes: 9 additions & 2 deletions extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExtensionContext, CancellationToken, commands } from 'vscode';
import { ExtensionContext, CancellationToken, commands, EventEmitter } from 'vscode';
import { Credentials } from '../authentication';
import { Logger } from '../logging';
import * as ghApiClient from './gh-api/gh-api-client';
Expand All @@ -9,17 +9,22 @@ import {
} from './gh-api/variant-analysis';
import { VariantAnalysisMonitorResult } from './shared/variant-analysis-monitor-result';
import { processFailureReason, processUpdatedVariantAnalysis } from './variant-analysis-processor';
import { DisposableObject } from '../pure/disposable-object';

export class VariantAnalysisMonitor {
export class VariantAnalysisMonitor extends DisposableObject {
// With a sleep of 5 seconds, the maximum number of attempts takes
// us to just over 2 days worth of monitoring.
public static maxAttemptCount = 17280;
public static sleepTime = 5000;

private readonly _onVariantAnalysisChange = this.push(new EventEmitter<VariantAnalysis | undefined>());
readonly onVariantAnalysisChange = this._onVariantAnalysisChange.event;

constructor(
private readonly extensionContext: ExtensionContext,
private readonly logger: Logger
) {
super();
}

public async monitorVariantAnalysis(
Expand Down Expand Up @@ -61,6 +66,8 @@ export class VariantAnalysisMonitor {

variantAnalysis = processUpdatedVariantAnalysis(variantAnalysis, variantAnalysisSummary);

this._onVariantAnalysisChange.fire(variantAnalysis);

void this.logger.log('****** Retrieved variant analysis' + JSON.stringify(variantAnalysisSummary));

if (variantAnalysisSummary.scanned_repositories) {
Expand Down